fix: accessibility for apperance - #62489
Conversation
Signed-off-by: Kristian Zendato <kristian.zendato@nextcloud.com>
bdd1aba to
cd5393a
Compare
| alt="" | ||
| class="theming__preview-image" | ||
| :src="imageUrl" | ||
| <button |
There was a problem hiding this comment.
This is not valid you cannot have a checkbox inside a button.
This should be just a DIV element and checkbox within already is the semantic input element.
There was a problem hiding this comment.
So the outer elements needs to be a div and the outer fieldset needs a role="radiogroup".
|
|
||
| <div :class="$style.backgroundSelect"> | ||
| <!-- Custom background --> | ||
| <ul |
There was a problem hiding this comment.
why?
This is semantically not really correct, fieldset already was correct.
As this is a group of related input fileds. Its not really a list.
There was a problem hiding this comment.
https://github.com/nextcloud-gmbh/customer-feature-requests/issues/1624
Related to this feedback, they want the background to be HTML list.
There was a problem hiding this comment.
But thats invalid see my feedback on the issue. IMHO a false-positive text and should be closed as wont fix with proper reference to WCAG rules as the current semantics are correct (expect my other comment above).
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
See my comment - parially the issue is wrong as semantics for WCAG needs radiogroup and radio within the theme selection.
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
2 participants
Summary
Checklist
3. to review, feature component)stable32)AI (if applicable)